Conversation
mjohnson541
added
Status: Ready for Review
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 41.84% 41.85% +0.01%
==========================================
Files 165 165
Lines 28010 28014 +4
Branches 5714 5716 +2
==========================================
+ Hits 11721 11726 +5
Misses 15500 15500
+ Partials 789 788 -1
Continue to review full report at Codecov.
|
Member
|
Looking great! Can you add test/s? |
Contributor
Author
|
Done |
mjohnson541
force-pushed
the
rdmolhbond
branch
from
0f56707 to
c893273
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets RMG ignore hydrogen bonds when converting a molecule to an RDKit mol.