Conversation
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
=======================================
Coverage 42.02% 42.02%
=======================================
Files 165 165
Lines 27867 27867
Branches 5680 5680
=======================================
Hits 11711 11711
Misses 15371 15371
Partials 785 785Continue to review full report at Codecov.
|
mliu49
requested changes
Jan 24, 2019
Contributor
mliu49
left a comment
mliu49
left a comment
There was a problem hiding this comment.
Actually, could you add a simple unit test?
Contributor
|
I added a new test module for RMG object. One of the tests is actually failing, which I'm glad was caught. If the value is a numpy array, then directly checking the truth value is ambiguous and raises an exception. |
Member
Author
|
Great catch! Thanks for adding this test |
Contributor
|
The fix looks good! You can go ahead and squash. |
Don't bother dumping and parsing empty objects (usually an empty list)
Member
Author
|
done! |
mliu49
approved these changes
Jan 25, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
When RMGObject encounters an empty list, it cannot index it (e.g., call
val[0]). This occures when running atomic species where the frequencies are just an empty list[].Description of Changes
We shouldn't bother dumping and parsing empty lists, they will get their default values when loading the object.
Testing
Files for testing (for carbon atom) are attached
C_arkane_input.txt
input.txt
sp.txt
Reviewer Tips
After successfully generating a YAML file for C, try feeding that YAML file back to Arkane to see that it reads it correctly.