Skip to content

None of our regression tests use RMS reactors #2442

@rwest

Description

@rwest

The testing framework runs the examples in RMG-Py/test/regression
which use the following reactor types:

aromatics/input.py:simpleReactor(
liquid_oxidation/input.py:liquidReactor(
nitrogen/input.py:simpleReactor(
oxidation/input.py:simpleReactor(
sulfur/input.py:simpleReactor(
sulfur/input.py:simpleReactor(
superminimal/input.py:simpleReactor(

so the RMS reactor types are not being tested in this CI framework.

I think at least one of the regression tests should use an RMS reactor, so that a "full run" of RMG that uses RMS is tested via CI.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions