-
Notifications
You must be signed in to change notification settings - Fork 252
Closed
Labels
Good First IssueStatus: Fixed in PRThis issue has been fixed by an active PRThis issue has been fixed by an active PRTopic: Performance
Description
I noticed that we're running some calculations to determine fitting error when converting between different thermo formats in thermoengine: https://github.com/ReactionMechanismGenerator/RMG-Py/blob/master/rmgpy/thermo/thermoengine.py#L101
Since we aren't using the result in any way, it seems pointless to run the calculations during a normal job.
This probably doesn't cost that much, but may be worth addressing.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Good First IssueStatus: Fixed in PRThis issue has been fixed by an active PRThis issue has been fixed by an active PRTopic: Performance