Skip to content

Unnecessary calculations when generating thermo #1812

@mliu49

Description

@mliu49

I noticed that we're running some calculations to determine fitting error when converting between different thermo formats in thermoengine: https://github.com/ReactionMechanismGenerator/RMG-Py/blob/master/rmgpy/thermo/thermoengine.py#L101

Since we aren't using the result in any way, it seems pointless to run the calculations during a normal job.

This probably doesn't cost that much, but may be worth addressing.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions