Skip to content

frequencyScaleFactor in Arkane examples might not be used except in input.py #1655

@amarkpayne

Description

@amarkpayne

Bug Description

frequencyScaleFactor is defined in the arkane example file RMG-Py/examples/arkane/species/C2H6/C2H6.py. However, this factor is being overwritten by the scale factor for the model chemistry. Interestingly though, defining frequencyScaleFactor in RMG-Py/examples/arkane/species/C2H6/input.py does overwrite the model chemistry as expected.

Given this, it is possible that defining frequencyScaleFactor outside of the input.py file has no effect. At the very least though, we should add a comment to these example files outlining what happens to this parameter when defined in the species files instead of the input file

How To Reproduce

Run this Arkane example, then look at the output YAML file.

Additional Context

I am not certain that this is a bug, or that we need to do anything at all yet, but I am documenting this here so that I follow-up on this. After I do a little more digging (including a closer look at the documentation, perhaps I missed a section that clearly explains this) I'll push any necessary changes.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions