proper skip omp parallel loops in froll #7376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7376 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 85 85
Lines 16449 16449
=======================================
Hits 16304 16304
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jangorecki
added a commit
that referenced
this pull request
Oct 19, 2025
* frollvar and frollsd * export * news entry for var and sd * codecov fix * handle var < 0 spotted by Ben * elaborate more on fall back to slow when NAs are in the input * align to changes proposed in #7376 * reuse existing macro as per Ben suggestion
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #7371
I am not closing linked issue because there may be other places in code where this is still relevant.
Implementation decided based on benchmarks in #7372