no longer having C frollapply, follow-up of #7272 #7290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7290 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 83 83
Lines 15703 15703
=======================================
Hits 15558 15558
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=frollapply-followup-no-c Generated via commit 8595ae4 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
Jan FYI please try to remember the GitHub UI doesn't support issue linking from the PR title so it's best to put #7272 in the PR description somewhere (I wish GitHub would solve this as it's a pain) |
Member
|
seems it's been sitting unaddressed for some years 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove dead entry from data.table.h
This work was supported by the Medical Research Council, UK [grant number 1573].