left aligned, adaptive, rolling max #7264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* frollmax exact, buggy fast, no fast adaptive * frollmax fast fixing bugs * frollmax man to fix CRAN check * frollmax fast adaptive non NA, dev * froll docs, adaptive left * no frollmax fast adaptive * frollmax adaptive exact NAs handling * PR summary in news * align happens in one place, less duplicated code * push up even more to frollR to reduce code duplication * frollapply push up align arg and early stopping up * typo fix in NEWS.md Co-authored-by: Marco Colombo <[email protected]> * keep R agnostic C code in froll.c, yet deduplicated * new functionality unit tests * doc further improving * tests and NEWS * remove unnecessary new line to reduce diff * Many wording corrections by Ben Co-authored-by: Benjamin Schwendinger <[email protected]> * function args, suggested by Ivan * Add wording improvements by Ivan Co-authored-by: aitap <[email protected]> * follow up improvements added to TODO file --------- Co-authored-by: Marco Colombo <[email protected]> Co-authored-by: Benjamin Schwendinger <[email protected]> Co-authored-by: aitap <[email protected]>
* catf rather than cat * malloc and free as per feedback * remove R < 3.4.0 related code * rm TODO file
This was referenced Aug 27, 2025
mcol
reviewed
Aug 27, 2025
Co-authored-by: Marco Colombo <[email protected]>
jangorecki
commented
Aug 28, 2025
jangorecki
commented
Aug 28, 2025
Member
Author
|
For now I have reverted atime test script and merged fresh master, to have this PR in a ready-to-merge state. |
Member
|
that is fine, no need to add atime tests, lgtm. |
ben-schwen
approved these changes
Aug 28, 2025
Member
ben-schwen
left a comment
ben-schwen
left a comment
There was a problem hiding this comment.
Some small things but overall LGTM
Co-authored-by: Michael Chirico <[email protected]>
mcol
reviewed
Aug 28, 2025
Co-authored-by: Marco Colombo <[email protected]>
This was referenced Aug 29, 2025
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fresh attempt of #5441 which has been split in multiple smaller PRs.
10 smaller PRs have been already individually reviewed and merged to this dev branch, which now here is proposed to master.
This PR will supersede the following PRs: #5441, #5890, #5891, #5892, #5893, #5894, #5895, #5896, #5897, #5898
Scope
adaptive && align="left"Adaptive, left-aligned rolling max #5438frollmaxadaptive (exact) Adaptive, left-aligned rolling max #5438frollmax(fast, exact) rolling functions, rolling aggregates, sliding window, moving average #2778give.namesargument rolling functions, rolling aggregates, sliding window, moving average #2778frollapplyadaptive Adaptive, left-aligned rolling max #5438partial2adaptive,coerceK,ansSetMsg, or redirectingfrollapplytofroll) ofalignalgo="fast"support forInfand-Inf(breaking change).hasNAtohas.nf(has non-finite)Closes #5438, #4968 and #5306.
Benchmarks
algo="exact"only); benchmark code in NEWS.md filerolllibraryThis work was supported by the Medical Research Council, UK [grant number 1573].