NumFOCUS changes #6979
NumFOCUS changes #6979
Conversation
Add Powered by NumFocus
fix badge location
Add link (not yet active) to NumFOCUS donation page. Add tax language from NumFOCUS. Remove placeholder text for pre-NumFOCUS funding structure.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6979 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 79 79
Lines 14676 14676
=======================================
Hits 14485 14485
Misses 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GOVERNANCE.md
Outdated
| # Finances and Funding | ||
|
|
||
| There is currently no mechanism for the data.table project to receive funding as an entity. | ||
| The data.table project is fiscally sponsored by [NumFOCUS](https://numfocus.org/). Donations to the project can be made at [numfocus.org/donate-to-data-table](https://numfocus.org/donate-to-data-table) |
There was a problem hiding this comment.
I don't really know how NumFOCUS funding works, but as long as there are no funds coming from it, I would phrase it "project can be fiscally sponsored via NumFOCUS".
There was a problem hiding this comment.
This is a good point that it can be assumed that funding is automatically coming in based on this but I do believe it is correct is say "is fiscally sponsored by" as NUMFocus is taking on the project now and any funds that do come to data.table will be supported by them.
Would it be useful to say "The data.table project is fiscally sponsored by NumFOCUS based on donations and grant funding when available. Donations to the project can be made at numfocus.org/donate-to-data-table
There was a problem hiding this comment.
Saying that "project is [already] fiscally sponsored" is a bit more discouraging new potential sponsors, comparing to saying "project can be fiscally sponsored". Ultimately I don't have strong opinion on that, let's see what others think.
There was a problem hiding this comment.
This language came directly from NumFOCUS, but I agree with Jan's take - we'll ask them in our meeting next week if the language can be tweaked to clarify in some way that we receive sponsorship via donations through the NumFOCUS platform.
fix donation link and tweak language
|
@TysonStanley, could you also please make sure to squash when merging so that we have a clean history? (I know that GitHub has changed the default option here, which makes it more tedious.) |
4 participants
Closes #5675
This PR incorporates changes, in compliance with our recent acceptance to be fiscally sponsored by NumFOCUS.
Please do not merge until:
Donation and landing page links are verified; current ones are placeholders.
NumFOCUS onboarding has taken place and everything has been reviewed.
(ping @TysonStanley)