Please add a NEWS entry.

I am wondering if setselfref() itself should just be a no-op on non-data.table. setselfref() is also used in subset:

Is it possible to wind up running that on a data.frame?

Last, I see we still SETLENGTH/SETTRUELENGTH for the data.frame input -- might that be problematic?

Generated via commit 4da8e65

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 26 seconds

Time taken to run atime::atime_pkg on the tests: 7 minutes and 29 seconds

Added a NEWS item. Agreed that making setselfref a no-op for data frames is safer - fixed.

Not sure why a conflict resolution was needed (didn't actually 'resolve' anything manually). Anyway should be good to go now.

(Text-only approval since I'm technically the PR author here)

Thanks!

Sorry it took so long to review such a tiny change 🙏

Sorry it took so long to review such a tiny change 🙏

Thanks for merging, that was very fast.