Skip to content

Run linters on test scripts #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelChirico merged 6 commits into from
May 4, 2024
Merged

Run linters on test scripts #6121

MichaelChirico merged 6 commits into from
May 4, 2024

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 3, 2024 •
edited
Loading

The default pattern for files to lint is pattern = "(?i)[.](r|rmd|qmd|rnw|rhtml|rrst|rtex|rtxt)$", i.e. not Rraw. We don't need the other extensions, so trim them also for simplicity.

See:

https://lintr.r-lib.org/reference/lint.html

This was referenced May 3, 2024
Merged
Merged
Merged
@MichaelChirico Graphite App
Copy link
Member Author

MichaelChirico commented May 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite Graphite

@MichaelChirico MichaelChirico mentioned this pull request May 3, 2024
Merged
@MichaelChirico MichaelChirico changed the title lint-tests Run linters on tests.Rraw May 3, 2024
@MichaelChirico MichaelChirico changed the title Run linters on tests.Rraw Run linters on test scripts May 3, 2024
@tdhock
Copy link
Member

tdhock commented May 3, 2024

another option would be to change the Rraw to R as was discussed somewhere else?

MichaelChirico
MichaelChirico commented May 3, 2024
View reviewed changes
@MichaelChirico
Copy link
Member Author

MichaelChirico commented May 3, 2024

another option would be to change the Rraw to R as was discussed somewhere else?

yes! I had a TODO at some point but must have lost it. That issue won't be fixed for some time I believe, until we burn down most of the existing PR queue.

@MichaelChirico MichaelChirico marked this pull request as ready for review May 3, 2024 14:11
@tdhock
Copy link
Member

tdhock commented May 3, 2024

ok great

@MichaelChirico MichaelChirico force-pushed the 05-02-lint-test-literal branch from 00b1406 to 1d045f8 Compare May 3, 2024 18:51
@MichaelChirico Graphite App
Copy link
Member Author

MichaelChirico commented May 4, 2024 •
edited
Loading

Merge activity

@MichaelChirico MichaelChirico force-pushed the 05-02-lint-test-literal branch from 1d045f8 to ed0d93d Compare May 4, 2024 16:14
Base automatically changed from 05-02-lint-test-literal to master May 4, 2024 16:16
@MichaelChirico MichaelChirico merged commit ca815ba into master May 4, 2024
@MichaelChirico MichaelChirico deleted the 05-02-lint-tests branch May 4, 2024 16:23
This was referenced Jul 1, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdhock tdhock tdhock approved these changes

@jangorecki jangorecki jangorecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelChirico @tdhock @jangorecki