Skip to content

New linter for test(symbol) #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelChirico merged 1 commit into from
May 4, 2024
Merged

New linter for test(symbol) #6120

MichaelChirico merged 1 commit into from
May 4, 2024

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 3, 2024 •
edited
Loading

This is a follow-up to #6041 that will prevent regression on that front going forward.

This was referenced May 3, 2024
Merged
Merged
@MichaelChirico Graphite App
Copy link
Member Author

MichaelChirico commented May 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite Graphite

@MichaelChirico MichaelChirico mentioned this pull request May 3, 2024
Merged
@MichaelChirico MichaelChirico changed the title lint-test-literal New linter for test(symbol) May 3, 2024
@MichaelChirico MichaelChirico marked this pull request as ready for review May 3, 2024 05:27
@MichaelChirico MichaelChirico mentioned this pull request May 3, 2024
Merged
@tdhock
Copy link
Member

tdhock commented May 3, 2024

great but do we need to turn off the linter in test(variable, which happens a couple of times right?

@MichaelChirico
Copy link
Member Author

MichaelChirico commented May 3, 2024

great but do we need to turn off the linter in test(variable, which happens a couple of times right?

it only happens once now in tests.Rraw (hence the nolint). It happens a few more times in froll, hence the config entry in #6121. I'd rather not touch those tests until the existing froll PRs are eventually cleared.

@tdhock
Copy link
Member

tdhock commented May 3, 2024

great

@MichaelChirico MichaelChirico force-pushed the 05-02-lint-test-literal branch from 00b1406 to 1d045f8 Compare May 3, 2024 18:51
@MichaelChirico Graphite App
Copy link
Member Author

MichaelChirico commented May 4, 2024 •
edited
Loading

Merge activity

@MichaelChirico MichaelChirico changed the base branch from lint-lengths to master May 4, 2024 16:13
@MichaelChirico MichaelChirico force-pushed the 05-02-lint-test-literal branch from 1d045f8 to ed0d93d Compare May 4, 2024 16:14
@MichaelChirico MichaelChirico merged commit b94b7ca into master May 4, 2024
@MichaelChirico MichaelChirico deleted the 05-02-lint-test-literal branch May 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdhock tdhock tdhock approved these changes

@jangorecki jangorecki jangorecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelChirico @tdhock @jangorecki