Gforce eval vars #5887
Merged
Gforce eval vars #5887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5887 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 80 80
Lines 14862 14862
=======================================
Hits 14488 14488
Misses 374 374 ☔ View full report in Codecov by Sentry. |
MichaelChirico
approved these changes
Jan 7, 2024
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Minor point on tests, LGTM otherwise. feel free to merge
MichaelChirico
approved these changes
Jan 8, 2024
Member
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #5548
Problems are j arguments of the form
x[y].yis indeed numeric. This was already partially done by enforcingy>0but didn't blocky==TRUE.data.tableWe could possible add a check to enforce
xbeing a column in the data.table but this would deactive GForce for.I[1]expressions. Plus we already have the check that x should be atomic in the environment of the data.table.Revdep checks: