Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (6f3fc8d) to head (4469b48).
Report is 34 commits behind head on master.

❗ Current head 4469b48 differs from pull request most recent head 3cf6328. Consider uploading reports for the commit 3cf6328 to get more accurate results

@@            Coverage Diff             @@
##           master    #5838      +/-   ##
==========================================
- Coverage   97.51%   97.48%   -0.04%     
==========================================
  Files          80       80              
  Lines       14979    14859     -120     
==========================================
- Hits        14607    14485     -122     
- Misses        372      374       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jangorecki anything to change here before merging to 1-15-99?

In some PRs I recall using 3.1's (vapply's) lengths(). It may be better re-run lint/grep after merging PRs in the queue and catching all usage, not just current master.

Still it would be good to turn on 3.2.0 ASAP to allow using the new functions. WDYT about this approach:

1. This PR simply flips the DESCRIPTION dep
2. Next PR turns on CI for linting
3. Then we apply the rest of this PR, i.e. switching to 3.2.0+ "style" internally
4. Turn on a linter for preventing backsliding

That way, we're "allowed" to use 3.2.0 sooner, but only "enforce" doing so all at once.

Generated via commit 3cf6328

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 27 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 15 seconds

@tdhock this is ready for review now that we have linting in CI. #6100 (downstream of this in Graphite stack) has the custom linter referenced to help prevent backsliding.

• Run linters on test scripts #6121
• New linter for test(symbol) #6120
• customize lengths_linter for data.table usage #6100
• get code for custom linters working #6099
• Use R 3.2.0 features #5838 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite

Thanks for the reviews @tdhock, this PR is also part of the same "stack" -- I can submit them all at once with your review here. 🎉

Merge activity

• May 4, 12:06 PM EDT: @MichaelChirico started a stack merge that includes this pull request via Graphite.
• May 4, 12:07 PM EDT: @MichaelChirico merged this pull request with Graphite.