Fix #5286 #5556
Closed
Fix #5286 #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test(1984.26, setalloccol(`*tmp*`), error='setalloccol attempting to modify `*tmp*`') | ||
| DF = as.data.frame(DT) | ||
| test(1984.27, shallow(DF), DF) # shallow (which is not exported) works on DF from v1.14.2 | ||
| test(1984.27, identical(shallow(DF), DF), TRUE) # shallow (which is not exported) works on DF from v1.14.2 |
Member
There was a problem hiding this comment.
Suggested change
| test(1984.27, identical(shallow(DF), DF), TRUE) # shallow (which is not exported) works on DF from v1.14.2 | |
| test(1984.27, identical(shallow(DF), DF)) # shallow (which is not exported) works on DF from v1.14.2. identical() to force checking the selfref attribute |
Member
|
Hi @OfekShilon thanks for the PR. Would you like to take it back up? If so, please:
|
Member
|
Feel free to re-open if you'd like to continue this PR. Thanks! |
Contributor
Author
|
@MichaelChirico I no longer work in IstraResearch and have no access to that fork. |
Member
|
Got it. would you like to continue the PR if I publish the branch back to the main repo here? |
Contributor
Author
|
I can try.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.