Gforce weighted.mean #5246
Merged
Gforce weighted.mean #5246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5246 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 77 77
Lines 14639 14645 +6
=======================================
+ Hits 14567 14573 +6
Misses 72 72
Continue to review full report at Codecov.
|
jangorecki
reviewed
Nov 3, 2021
Member
|
This seems to fail on R 3.5 and older |
mattdowle
added a commit
that referenced
this pull request
Dec 3, 2021
…h 'invalid first argument'; removing it passed all tests so it wasn't covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3977
As pointed in the issue its faster (at least on my multi-core machine) to double call
gsumdue to #3202 than providing an implementation similar to e.g.gsd/gvar.