First look for .datatable.aware in environment #4909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, @hadley. Great solution. |
Contributor
Author
|
Got it, thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR requested by @MichaelChirico to kick off discussion of the issue described in tidyverse/dtplyr#184 — i.e., it would be nice if dtplyr could declare the code that it generates and evaluates is data.table aware, independently of what package that is running that code.
If this idea seems interesting/promising I'm happy to finish off with a NEWS bullet, tests (although I'm not yet sure how to test this specific), etc. But I wanted to make sure this contribution was appropriate before doing more work.