towards #4200, overhead in dogroups #4558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangorecki
commented
Jun 18, 2020
src/subset.c
Outdated
| #define PARLOOP(_NAVAL_) \ | ||
| if (anyNA) { \ | ||
| _Pragma("omp parallel for num_threads(getDTthreads(n, true))") \ | ||
| _Pragma("omp parallel for num_threads(nth)") \ |
Member
Author
There was a problem hiding this comment.
- tried turning it into
omp parallel for if (nth > 1) num_threads...but it makes no difference. - tried using
if (nth > 1) _Pragma("...")but it makes result a garbage
so I ended up duplicating whole macro for single threaded mode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4558 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 73 73
Lines 14118 14119 +1
=======================================
+ Hits 14063 14064 +1
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I also tried simpler approach, eliminating |
mattdowle
approved these changes
Jun 26, 2020
This was referenced Jul 17, 2024
MichaelChirico
added
the
atime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timings in #4200 (comment)
probably qualifies to close #4200