Skip to content

Internal class aware coerceAs. Already used in nafill and froll #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdowle merged 37 commits into from
Mar 8, 2021
Merged

Internal class aware coerceAs. Already used in nafill and froll #4491

mattdowle merged 37 commits into from
Mar 8, 2021

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented May 25, 2020 •
edited by mattdowle
Loading

closes:

@jangorecki jangorecki added the WIP label May 25, 2020
This was linked to issues May 25, 2020
Extend functionality of nafill to use 'fill' argument for all 'type's #3594
Closed
class-aware C coercion function, no-alloc coerce where possible #3913
Closed
@codecov
Copy link

codecov bot commented May 25, 2020 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.28358% with 9 lines in your changes missing coverage. Please review.

Project coverage is 99.40%. Comparing base (3fa8b20) to head (909add0).
Report is 1468 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.c 80.43% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4491      +/-   ##
==========================================
- Coverage   99.46%   99.40%   -0.07%     
==========================================
  Files          73       73              
  Lines       14414    14417       +3     
==========================================
- Hits        14337    14331       -6     
- Misses         77       86       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MichaelChirico
MichaelChirico reviewed May 26, 2020
View reviewed changes
MichaelChirico
MichaelChirico reviewed May 26, 2020
View reviewed changes
@jangorecki jangorecki mentioned this pull request May 26, 2020
Closed
@jangorecki jangorecki mentioned this pull request May 27, 2020
Closed
@jangorecki jangorecki linked an issue May 27, 2020 that may be closed by this pull request
nafill() should coerce fill="2" to 2L (for example) without warning #4503
Closed
@mattdowle
Copy link
Member

mattdowle commented Mar 8, 2021

Have seen the missed coverage in new coerceAs. Sounds like future PRs will address that.

@mattdowle mattdowle merged commit 85adf09 into master Mar 8, 2021
@mattdowle mattdowle deleted the coerceAs branch March 8, 2021 00:11
@jangorecki jangorecki mentioned this pull request Mar 8, 2021
Merged
@ben-schwen ben-schwen mentioned this pull request Dec 12, 2021
Closed
@tlapak tlapak mentioned this pull request Apr 10, 2022
Closed
@ColeMiller1 ColeMiller1 mentioned this pull request Apr 16, 2022
Closed
@tdhock tdhock mentioned this pull request Jul 26, 2022
Closed
@tdhock tdhock restored the coerceAs branch July 27, 2022 18:55
@mattdowle mattdowle deleted the coerceAs branch October 14, 2022 19:23
@tdhock tdhock restored the coerceAs branch September 12, 2023 17:55
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
@tdhock tdhock mentioned this pull request Mar 5, 2024
Closed
@tdhock tdhock mentioned this pull request Mar 14, 2024
Merged
Anirban166 added a commit to Anirban166/data.table that referenced this pull request Mar 19, 2024
@Anirban166
Added a test case which is not relevant or related to Rdatatable#4491/R…
ef2db64 
…datatable#5463
@Anirban166 Anirban166 mentioned this pull request Apr 3, 2024
Closed
Anirban166 added a commit to Anirban166/data.table that referenced this pull request Apr 6, 2024
@Anirban166
Merge pull request #2 from Anirban166/after-4491-got-merged
fa25e82 
GitHub Action + atime test to observe the performance regression introduced by PR Rdatatable#4491 and fixed by PR Rdatatable#5463
@Anirban166 Anirban166 mentioned this pull request Apr 9, 2024
Open
This was referenced May 28, 2024
Closed
Closed
Closed
@Nj221102 Nj221102 mentioned this pull request Jun 12, 2024
Draft
4 tasks
@MichaelChirico MichaelChirico added the atime Requests related to adding/improving/monitoring performance regression tests via atime. label Jul 8, 2025
@jangorecki jangorecki deleted the coerceAs branch September 27, 2025 09:18
@MichaelChirico MichaelChirico restored the coerceAs branch October 20, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdowle mattdowle mattdowle left review comments

@MichaelChirico MichaelChirico MichaelChirico left review comments

Assignees

No one assigned

Labels

atime Requests related to adding/improving/monitoring performance regression tests via atime. High

Projects

None yet

Milestone

1.15.0

4 participants

@jangorecki @GreenGrassBlueOcean @mattdowle @MichaelChirico