order optimizes to forderv, uses key or index, forder more consistent to base order #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #4458 +/- ##
==========================================
- Coverage 99.61% 99.59% -0.02%
==========================================
Files 72 72
Lines 13917 13967 +50
==========================================
+ Hits 13863 13911 +48
- Misses 54 56 +2
Continue to review full report at Codecov.
|
3 tasks
jangorecki
commented
May 18, 2020
| o | ||
| if (!is.logical(decreasing) || anyNA(decreasing)) stop("'decreasing' must be logical non-NA") | ||
| if (length(decreasing)!=1L && length(decreasing)!=length(data)) stop("'decreasing' must be either length 1, or length of the variables passed to [f]order") | ||
| asc[decreasing] = -(asc[decreasing]) |
Member
Author
There was a problem hiding this comment.
[.integer automatically recycle scalar decreasing
Member
Author
|
marking as WIP because it will need rebase over lazy-forder branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
DT[order(.)]could utilize existing indexordercould utilize existing index #3023 (once Teach forder to re-use existing key and index attributes instead of sorting from scratch #4386 merged) - this one and the next, setindex, is being tested on lazy-forder branch after merging this PR inopt-order-lazybranchDT[order(.), ...]could create index on DTDT[order(.), ...]could create index on DT #3261 (once Teach forder to re-use existing key and index attributes instead of sorting from scratch #4386 merged, andsetindexfrom C forder enabled)fordermanual, doesn't have to be exported, a lot to migrate fromsetorder.Rd, partly done in setorderv gets new arg neworder, closes #4012 #4340To reduce number of API changes (in still internal
forder[v]) I am not going to yet close this issue:It is partially addressed by making
fordercompatible withbase::order, but this PR does not restrict input types. Lets see what base R is planning to do aboutorder(df)(see R-devel discussion), and in another iteration we can solve #4346 and #4214.It also makes
na.last=NAoption inforderconsistent to baseorderby removing 0's that are result fromforderv(na.last=NA).