Skip to content

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Apr 2, 2020

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1b1832) 99.61% compared to head (5541e9c) 99.61%.
Report is 596 commits behind head on master.

❗ Current head 5541e9c differs from pull request most recent head 3b18044. Consider uploading reports for the commit 3b18044 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4340   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          72       72           
  Lines       13916    13935   +19     
=======================================
+ Hits        13862    13881   +19     
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jangorecki jangorecki added the WIP label May 18, 2020
@jangorecki
Copy link
Member Author

jangorecki commented May 18, 2020

failure of CI in this PR

* checking Rd cross-references ... WARNING
Missing link or links in documentation object 'frank.Rd':
  'forder'
Missing link or links in documentation object 'openmp-utils.Rd':
  'forder'
Missing link or links in documentation object 'setorder.Rd':
  'forder'
See section 'Cross-references' in the 'Writing R Extensions' manual.

is related to moving alias forder into new manual file. That will happen in #4458, so we may want to wait with merging this one till #4458 is merged.
https://github.com/Rdatatable/data.table/blob/opt-order/man/forder.Rd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setorderv could take index vector too Incomplete dox in ?setorder

2 participants