Skip to content

setnames match to dup in colnames downgraded from error to warning #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdowle merged 1 commit into from
Sep 10, 2019
Merged

setnames match to dup in colnames downgraded from error to warning #3853

mattdowle merged 1 commit into from
Sep 10, 2019

Conversation

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 10, 2019

Resolves tsbox in #3581

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 10, 2019
@mattdowle mattdowle mentioned this pull request Sep 10, 2019
Closed
31 tasks
@mattdowle
Copy link
Member Author

mattdowle commented Sep 10, 2019 •
edited
Loading

Upload of codecov results failed with timeout error. Happens a fair bit. Low risk to proceed anyway and coverage will catch up on master anyway.

Still running (6 of 20): Rscript -e library(covr); codecov()
The command Rscript -e library(covr); codecov() exited with 1.
Log:
Error in curl::curl_fetch_memory(url, handle = handle) : 
  Timeout was reached: Connection timed out after 10000 milliseconds
Calls: codecov ... request_fetch -> request_fetch.write_memory -> <Anonymous>
Execution halted
/home/travis/.travis/functions: line 537: 14765 Terminated
    travis_jigger "${!}" "${timeout}" "${cmd[@]}"

I raised a PR a month ago to enhance the curl error message so we know the domain that is failing. So we can do something about it. jeroen/curl#191

@mattdowle mattdowle merged commit 9c1cc77 into master Sep 10, 2019
@mattdowle mattdowle deleted the setnames_dup branch September 10, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.12.4

Development

Successfully merging this pull request may close these issues.

1 participant

@mattdowle