Skip to content

Conversation

@mattdowle
Copy link
Member

Towards #3581
R's duplicate() is not guaranteed not to return an ALTREP, and now we're seeing it not.
duplicate()=>copyAsPlain() due to some ALTREP 'wrappers' now percolating up in 4 revdeps: corpustools, mlr, tcpl, VIM

…ing up in 4 revdeps: corpustools, mlr, tcpl, VIM
@mattdowle mattdowle added this to the 1.12.4 milestone Aug 31, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #3805 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3805      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          71       71              
  Lines       13247    13262      +15     
==========================================
+ Hits        13170    13185      +15     
  Misses         77       77
Impacted Files Coverage Δ
src/wrappers.c 100% <100%> (ø) ⬆️
src/transpose.c 100% <100%> (ø) ⬆️
src/utils.c 100% <100%> (ø) ⬆️
src/coalesce.c 100% <100%> (ø) ⬆️
src/reorder.c 100% <100%> (ø) ⬆️
src/assign.c 100% <100%> (ø) ⬆️
src/fmelt.c 95.83% <100%> (ø) ⬆️
src/subset.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa38cd7...0818d17. Read the comment docs.

@mattdowle mattdowle merged commit 4dd9548 into master Sep 1, 2019
@mattdowle mattdowle mentioned this pull request Sep 2, 2019
31 tasks
@mattdowle mattdowle deleted the copyAsPlain branch September 3, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant