restrict negation in !with to unary -/! #3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3775 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 71 71
Lines 13225 13225
=======================================
Hits 13148 13148
Misses 77 77
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Aug 20, 2019
| if (is.call(jsub) && deparse(jsub[[1L]], 500L, backtick=FALSE) %chin% c("!", "-")) { # TODO is deparse avoidable here? | ||
| # 2109 we should only match unary - | ||
| if (is.call(jsub) && deparse(jsub[[1L]], 500L, backtick=FALSE) %chin% c("!", "-") && length(jsub) == 2L) { # TODO is deparse avoidable here? | ||
| notj = TRUE |
Member
There was a problem hiding this comment.
deparse(jsub[[1]]) == as.character(jsub)[[1]] afaik
Member
There was a problem hiding this comment.
@HughParsonage Yep - that works. Now I'm puzzled why the deparse was there to start with. Ah well, tests pass.
mattdowle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2109
Just as simple as Arun said 2 years ago 😅