Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3913
Internally used in
nafillfunctioncoerceFillhas been heavily modified, and renamed tocoerceClass. Main purpose of the function is to handle coercion between types/classes with care on int64.Comparing to previous
coerceFillversion, newcoerceClass:coerceVectoris used - as a result, consider char to int64 (coerceClass("1", list(integer(0), bit64::as.integer64(0)))). This is going to be addressed in this PR, placeholders are in place. Also there might be some missing warnings like (NA introduced by coercion, Int overflow), which are currently not checked/issued in our int / double / int64 handling.utils.c tests moved into own test script
motivation:
nafillfor types other than integer, numeric and int64in
assign,rbindlistand potentially other places where we need to take care of int64 NAs handling or other classes like #3654As of current moment I don't understand coverage issue, it reports few closing brackets
}that are not being covered. Maybe a matter of waiting for update.