Skip to content

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 26, 2019

Closes #1921

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #3604 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3604      +/-   ##
=========================================
+ Coverage   97.79%   97.8%   +<.01%     
=========================================
  Files          66      66              
  Lines       12904   12916      +12     
=========================================
+ Hits        12620   12632      +12     
  Misses        284     284
Impacted Files Coverage Δ
R/data.table.R 97.74% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6297c...8871115. Read the comment docs.

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #3604 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files          66       66              
  Lines       12915    12927      +12     
==========================================
+ Hits        12633    12645      +12     
  Misses        282      282
Impacted Files Coverage Δ
R/data.table.R 97.74% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d20594...e1ac663. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone May 29, 2019
@mattdowle mattdowle changed the title Closes #1921 -- order -> forder anywhere in i Optimize order -> forder anywhere in i May 29, 2019
@mattdowle mattdowle merged commit daf721a into master May 29, 2019
@mattdowle mattdowle deleted the forder_all_i branch May 29, 2019 01:42
@MichaelChirico MichaelChirico mentioned this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Also switch to forder on subsetted ordering in i

2 participants