Skip to content

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 4, 2019

Closes #2837
Simply document the potential issue & move on. Potential for an option to force an internal check is left open if it's demanded later on...

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #3541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3541   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          66       66           
  Lines       12647    12647           
=======================================
  Hits        12290    12290           
  Misses        357      357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...dac8870. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #3541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3541   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          66       66           
  Lines       12647    12647           
=======================================
  Hits        12290    12290           
  Misses        357      357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...dac8870. Read the comment docs.

@mattdowle mattdowle changed the title Closes #2837 -- add a note to documentation about duplicate assignment Add a note to documentation about duplicate assignment May 11, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 11, 2019
@mattdowle mattdowle merged commit a858972 into master May 11, 2019
@mattdowle mattdowle deleted the document_set_i_duplicates branch May 11, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: warn/error when updating and i has duplicates

2 participants