Skip to content

Conversation

@arunsrinivasan
Copy link
Member

@arunsrinivasan arunsrinivasan commented Jan 23, 2018

Closes #2313
Very simple fix. Should be straightforward.

@codecov-io
Copy link

codecov-io commented Jan 23, 2018

Codecov Report

Merging #2583 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2583   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          63       63           
  Lines       12126    12126           
=======================================
  Hits        11088    11088           
  Misses       1038     1038
Impacted Files Coverage Δ
R/data.table.R 97.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d70de...b81a379. Read the comment docs.

@mattdowle mattdowle added this to the v1.10.6 milestone Jan 23, 2018
@mattdowle mattdowle merged commit b336e75 into master Jan 23, 2018
@mattdowle mattdowle deleted the issue-2313-nq-fix branch January 23, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

depending on order in j, x.* cols might not be found in non equi joins

3 participants