Fixed issue with potential spurious reordering introduced in #2389 #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.03%
==========================================
Files 62 62
Lines 12023 12025 +2
==========================================
- Hits 10983 10982 -1
- Misses 1040 1043 +3
Continue to review full report at Codecov.
|
mattdowle
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2372.
In my original implementation,
indices were treated like keys, i.e. on assining, they were shortened to the unaltered columns.
This could cause unexpected reordering during subsets.
The new implementation fixes the issue by doing the following if an index column has been assigned to:
length(idx)>0,it is dropped.integer(0), it is shortened to the unaltered columns because no reordering can occur.This rarely has practical implications at the moment but is important for consistency and potential extended use of indices in the future.