move/delete dangling ^^ comments from #5089

mattdowle · mattdowle · commit fae5952ee2ed · 2021-12-03T13:20:27.000-07:00
diff --git a/R/data.table.R b/R/data.table.R
@@ -1737,16 +1737,13 @@ replace_dot_alias = function(e) {
           if (!(is.call(q) && is.symbol(q[[1L]]) && is.symbol(q[[2L]]) && (q1 <- q[[1L]]) %chin% gfuns)) return(FALSE)
           if (!(q2 <- q[[2L]]) %chin% names(SDenv$.SDall) && q2 != ".I") return(FALSE)  # 875
           if ((length(q)==2L || (!is.null(names(q)) && startsWith(names(q)[3L], "na")))) return(TRUE)
+          #                       ^^ base::startWith errors on NULL unfortunately
           if (length(q)>=2L && q[[1L]] == "shift") {
             q_named = match.call(shift, q)
             if (!is.call(q_named[["fill"]]) && is.null(q_named[["give.names"]])) return(TRUE)
-          } # add gshift support
-          # weighted.mean #3977
-          if (length(q)>=3L && q[[1L]] == "weighted.mean") return(TRUE)
-          #                       ^^ base::startWith errors on NULL unfortunately
-          #        head-tail uses default value n=6 which as of now should not go gforce ... ^^
-          # otherwise there must be three arguments, and only in two cases:
-          #   1) head/tail(x, 1) or 2) x[n], n>0
+          }
+          if (length(q)>=3L && q[[1L]] == "weighted.mean") return(TRUE)  #3977
+          # otherwise there must be three arguments
           length(q)==3L && length(q3 <- q[[3L]])==1L && is.numeric(q3) &&
             ( (q1 %chin% c("head", "tail")) || ((q1 == "[" || (q1 == "[[" && eval(call('is.atomic', q[[2L]]), envir=x))) && q3>0L) )
         }
