fixed non-equi out of bounds read

mattdowle · mattdowle · commit 63f6e09c95df · 2023-02-16T04:03:32.000-05:00
diff --git a/NEWS.md b/NEWS.md
@@ -613,12 +613,12 @@
 
 # data.table [v1.14.8](https://github.com/Rdatatable/data.table/milestone/28?closed=1)
 
-## BUG FIXES
-
 ## NOTES
 
 1. Test 1613.605 now passes changes to `as.data.frame()` in R-devel, [#5597](https://github.com/Rdatatable/data.table/pull/5597). Thanks to Avraham Adler for reporting.
 
+2. An out of bounds read when combining non-equi join with `by=.EACHI` has been found and fixed thanks to clang ASAN, [#5598](https://github.com/Rdatatable/data.table/issues/5598). There was no bug or consequence because the read was followed (now preceded) by a bounds test.
+
 
 # data.table [v1.14.6](https://github.com/Rdatatable/data.table/milestone/27?closed=1)  (16 Nov 2022)
 
diff --git a/src/nqrecreateindices.c b/src/nqrecreateindices.c
@@ -26,7 +26,7 @@ SEXP nqRecreateIndices(SEXP xo, SEXP len, SEXP indices, SEXP nArg, SEXP nomatch)
   // TODO: revisit to see if this be simplified further when I've some time.
   R_len_t j=0, tmp=0;
   for (int i=0; i<n; ++i) {
-    if (ixo[j] <= 0 || j >= xn) {
+    if (j>=xn || ixo[j]<=0) {
       // NA_integer_ = INT_MIN is checked in init.c
       // j >= xn needed for special nomatch=NULL case, see issue#4388 (due to xo[irows] from R removing '0' value in xo)
       inewstarts[i] = inomatch;
