-
Notifications
You must be signed in to change notification settings - Fork 62
Major frontend redesign #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Aus-tin, I would like to make a few suggestions since I'm CyTube user for almost 5 years.
Other elements in your design very nice. It looks cool! 👍 |
|
Understood! Will work on implementing the features you listed back in.
Thank you so much for your feedback, knowing how SyncTube is actually used is super helpful! Will update soon! |
|
Hi, thank you very much for contribution, really shocked to see something like this here.
Well, this is feature for mobile browsers site fullscreen for less distraction, i guess this can be removed. But mobile layout in your redesign requres changes.
This is second thing that worries me. I feel like removing navbar makes it more difficult to add further features (aka geeky option buttons) to your design. Specifically:
This is reasons why i think something like navbar is decent here. We can do not show it by default and make something like "^" button in place of login/logout to show/hide navbar above video. Another alternative i can think of is gear button somewhere with some modal and all that configuration inside.
We can also add this as And last thing is browser compatibility: |
Redesign v2Okay! So I amended the original commit with the following updates. @aNNiMON1. Low light designThe active video indicator has been changed to a left accent border and the connection status has been changed to just the text being green. I eventually want to move it next to the online counter as you indicated though the element is connected to the message buffer so this will take a little more time. 2. Swap and SplitThese have been re-implemented. Since the new layout is based on a grid I opted for the the more current successor of split.js, split-grid. Swap is also back under the options panel (where the more button was previously). 3. TimestampI ended up keeping the HH:MM:SS format in favor of the possibility of adding an option to change the format in the future. Moved it to the first line like you suggested. @RblSbMobile ViewWhile mobile view is a useful feature, allowing SyncTube to work like a progressive web app may be a more elegant option. Bandcamp is known do do this, try going to this link on your phone and add the page to your home screen to see the differences. I also think this better suits SyncTube as a one channel web service using it more like an app. Plus this would work on both iPhone + Android, currently mobile view only works on the latter. ChatAs for chat, I like the idea of leaving chat under video, but would prefer to not move the html around. Maybe allowing the things in between to "collapse" would be a simpler solution (with a drop-down button for toggle) while using the native functionality of the "collapse" function. NavbarSo the reason I removed this and mitigated the features was due to the structure of the html. Optimally navigation/headers should be reserved for actual navigation (a big part of this is for accessibility reasons, and since there is only one page it made sense to move the features elsewhere). LOVE the idea of a modal though. One problem CyTube has is how unwieldy its options have gotten with almost too much to change. So I think a single page modal would work well! Let me know what you think! More buttonThis is working now and has been renamed to "options". The problem was with my CSS only implementation so I just opted for a simple 18 line script in Side noteCurrently split-grid is being called in Thank you and let me know it you have any more questions or suggestions! Going to start working on the mobile version of chat next! |
Interesting, but there is some problem: PWA requires https. Also, home screen icons is meh :)
Well, i think scrolling is little easier than showing/hiding controls and playlist for user, but some button next to the leader button can be fine too (don't know about some other place, because separated lines of collapsed content between chat and video still eats space that i want to keep). But in case of hide stuff button mobile gui can be less clear i think. With current layout moving two divs after chat are enough tho and it works nicely already.
Ugh, i think this is actually not that good, because you still need to push modal button to some place and modal hides almost the entire screen while open. So i still really miss header / menubar. There is another two points for it:
This is fine, can fix at merge stage. Looks cool. |
|
@Aus-tin wow, now it's perfect! Thanks! I'll try to switch to your branch in my synctube instance and test it a couple of days. |
|
Well, after three hours of testing I have some suggestions:
|
|
Good thoughts! Will apply changes soon, really like the idea of putting the settings in the chat since it gives it more room to breathe + doesn't cover the screen. Is this design alright with you @RblSb, I can put the header back but I also think @aNNiMON's suggestions work well. Would love to hear your thoughts! |
|
Yay, nice solution. Then i'm only concerned about mobile version. Do you ok with making player controls / playlist as separated components and move them around, or have some position options for show button? |
|
Think I'm going to go with your method of simply moving the controls & playlist below the chat. While I'm not too keen on moving the html I also don't completely like my idea of hiding things. Going to try and find a flexbox implementation but if that doesn't work I'll just write a script for it. Had the same thought about the leader button. Currently it will be aligned to the right next to the gear. |
Redesign v3ChangesSettingsMoved logout and clear chat to settings panel, settings panel is now located in the chat area. Added different sections for controls (currently chat label is showing because I'm assuming there's going to be more chat features than "clear chat"). Also, am planning on adding button toggles eventually but it can wait for now. Settings panel closes when logout/login and clear chat are clicked so user can see changes. Currently playingThe currently playing title is now truncated on desktop while on mobile it creates a newline. Scrollbar (not working)I had tried this originally as well by wrapping the Chat (mobile)Okay so for this I just reverted it back to the old layout with the chat on top and video on bottom. While I really like having the chat right under the video I think there may be some better ways to implement it. We can probably think this over some more before making a decision (maybe having chat be an overlay that can slide up from the bottom?) Let me know if there's anything else! |
|
@Aus-tin just switched to a new v3 design, everything is fine! I don't know how to stylize scrollbar on Chrome, but this works on Firefox: #messagebuffer {
scrollbar-color: var(--border) #111;
}Found small issues:
|
|
Example has been updated with fixes
|
|
@Aus-tin , as a user, I am not particularly familiar with the original CyTube, but I really like your last redesign, thanks! |
|
@Aus-tin some other things you want to do? Also please do not force-push if you can, i can squash your commits anyway. |
|
Understood, I think that's everything! (Sorry about the force pushing, wanted to amend the original commit) |
- Fix password input - Fix split and swap saving - Improve options panel with small chat - Fix emote sizes







Redesign v1
Hi! I've been using SyncTube for two weeks or so and noticed that most of the design was ported from CyTube. Thought there were some ways to improve the UI to make the user experience more into something that people are accustomed to (things like Netflix Party or Twitch). Currently there's a live version here: 149.28.243.90:4200 that will be up for a week or so. I have a more in depth explanation of some of the changes below and feel free to ask me any questions you have!
Almost a complete rewrite of the stylesheets
As I was going through the CSS there were a lot of things that were repeated from CyTube that weren't best practice. I tried to simplify things by mirroring the structure of the HTML behind it.
Make des.css primary stylesheet and remove CyTube, mobile view, and navbar styles
These were unnecessary due to the redesign, the idea is to have one stylesheet for the design and another for whatever custom CSS the user wants to use.
Remove mobile view, split, extend player, swap, video resize
Most of these video resizing features can be replicated by resizing the window. Mobile view is the equivalent of F11 for desktop users and didn't reflect the way users use video platforms (thinking YouTube/Twitch).
Though the one feature that could be useful was swap though this can be changed by a simple CSS declaration now as the UI is based on a grid. Or a simpler implementation could be sought out by, again, just changing the
grid-areaproperties.Remove chat timestamp
Copied from CyTube but it looks sooooooo much cleaner without it, wasn't really necessary either as the users are watching it in real time. Also every service I checked seemed to keep with a similar ethos (YouTube/Twitch again as well as Netflix Party).
Remove navbar
The redesign made this unnecessary, was able to move functionality into more fitting places.
Migrate from Glyphicons to Ionicons and change icons to more better reflect button functions
Moved away from Glyphicons in favor Ionicons. One of the big reasons was accessibility. Also changed some of the icons out to more accurately represent the function they performed.
Migrate from Play to Inter
More readable display font.
Change template url
While the current example video is visually really cool, the flashing back and forth carries the risk of causing seizures for users with epilepsy. I changed it to the first episode of this show here. Or if you want something more visually aesthetic I would suggest this video here.
Change common CSS properties to CSS variables
This was to make theming easier, all the user needs to do to change certain things now is just change the variable in their
custom.css. I was also planning on making a light theme as an alternative to the current dark theme.Add SimpleBar
Standardize the scrollbar across panels. Currently I was only able to get it in the
mainsection (which was thankfully the only place it was needed) but want to try to also get it working in themessagebufferandsmileswrapsections as well.Thank you for taking your time to read this and keep up the good work!