Skip to content
This repository was archived by the owner on Oct 30, 2021. It is now read-only.

Edit desktop entry to comply with Linux standards - Fixes #25 - #26

Merged
RazrFalcon merged 1 commit into
RazrFalcon:masterfrom
RohanVilloth:icon-theme-compatibility
Jan 13, 2016
Merged

Edit desktop entry to comply with Linux standards - Fixes #25#26
RazrFalcon merged 1 commit into
RazrFalcon:masterfrom
RohanVilloth:icon-theme-compatibility

Conversation

@RohanVilloth

Copy link
Copy Markdown
Contributor

Edited svgcleaner.desktop to comply with the Linux standard - freedesktop desktop entry specs and to ensure compatibility with icon themes. The following hardcoded icon path was removed:

Icon=/usr/share/icons/hicolor/scalable/apps/svgcleaner.svg

and replaced with the correct one:

Icon=svgcleaner

It may seem like just a cosmetic change, but standards compliance contributes to quality of the app. :bowtie:

@RazrFalcon

Copy link
Copy Markdown
Owner

I used full path, because some times is failed to find icon for some reasons...
Accepted.

RazrFalcon added a commit that referenced this pull request Jan 13, 2016
Edit desktop entry to comply with Linux standards - Fixes #25
@RazrFalcon
RazrFalcon merged commit cbf43fe into RazrFalcon:master Jan 13, 2016
@RohanVilloth
RohanVilloth deleted the icon-theme-compatibility branch January 13, 2016 14:58
@RohanVilloth

Copy link
Copy Markdown
Contributor Author

@RazrFalcon Thanx 4 accepting the commit! 😘 I'll now mark SVGCleaner as 'Fixed' in @Foggalong 's Hardcode Fixer App List. And don't worry about failing to load app icon, coz all well maintained distros comply to freedesktop standards and will load the icon fine.

By the way, will SVGCleaner PPA be updated for Ubuntu 16.04LTS? 😕 The builds in that PPA are like 2 years old now. 😞

@RazrFalcon

Copy link
Copy Markdown
Owner

Yep, project kinda dead. I'll try to update ppa, but I don't know if it will built successfully for new versions.

@RohanVilloth

Copy link
Copy Markdown
Contributor Author

I'll try to update ppa

@RazrFalcon That's great! 😇 Besides, SVGCleaner is still the best svg optimizer available natively on Linux. Do you know Numix Project uses svgcleaner-cli in their svgclean script to optimize icons?

@RazrFalcon

Copy link
Copy Markdown
Owner

Yep, but there are a lot of work left to do to release new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants