fix: Add labels to empty statement blocks for drag tests#2580
Merged
RoboErikG merged 2 commits intoRaspberryPiFoundation:masterfrom Jul 11, 2025
Merged
fix: Add labels to empty statement blocks for drag tests#2580RoboErikG merged 2 commits intoRaspberryPiFoundation:masterfrom
RoboErikG merged 2 commits intoRaspberryPiFoundation:masterfrom
Conversation
maribethb
approved these changes
Jul 11, 2025
RoboErikG
added a commit
to RoboErikG/blockly
that referenced
this pull request
Jul 11, 2025
This fixes the the toolbox categories tests except for dragging out the four empty statement blocks, which is fixed by RaspberryPiFoundation/blockly-samples#2580 Once the latest version of samples is published the toolbox suite can be re-enabled.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Necessary but not sufficient for RaspberryPiFoundation/blockly#9217
Proposed Changes
Adds a single character text label to each of the empty statement input test blocks.
Reason for Changes
The webdriver tests in main can't drag blocks that have a hole in the middle and no text label. In order to drag these four blocks out they need to have a label that can be used as the drag target element.
Test Coverage
Documentation
Additional Information