Skip to content

Opening help while in move mode throws failures #515

@BenHenning

Description

@BenHenning

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Since it's currently possible to use keyboard shortcuts while in move-block/drag mode, trying to open the list of shortcuts causes failures to be thrown.

Reproduction steps

  1. Open the playground.
  2. Navigate to a moveable block.
  3. Enter move mode with 'M'.
  4. Open the keyboard shortcuts list using '/'.
  5. Observe failures.

Stack trace

Two stack traces are observed (each is thrown twice, at least they were for me):

First:

This node is not focusable.
    at MoveIcon.getFocusableElement (webpack-internal:///./src/move_icon.ts:121:15)
    at WorkspaceSvg$$module$build$src$core$workspace_svg.lookUpFocusableNode (webpack-internal:///../blockly/dist/blockly_compressed.js:1312:430)
    at FocusableTreeTraverser$$module$build$src$core$utils$focusable_tree_traverser.findFocusableNodeFor (webpack-internal:///../blockly/dist/blockly_compressed.js:541:146)
    at b (webpack-internal:///../blockly/dist/blockly_compressed.js:543:673)
    at eval (webpack-internal:///../blockly/dist/blockly_compressed.js:544:307)
    at ShortcutDialog.toggleInternal (webpack-internal:///./src/shortcut_dialog.ts:77:37)
    at ShortcutDialog.toggle (webpack-internal:///./src/shortcut_dialog.ts:68:14)
    at Object.callback (webpack-internal:///./src/shortcut_dialog.ts:160:22)
    at ShortcutRegistry$$module$build$src$core$shortcut_registry.onKeyDown (webpack-internal:///../blockly/dist/blockly_compressed.js:1355:253)
    at onKeyDown$$module$build$src$core$inject (webpack-internal:///../blockly/dist/blockly_compressed.js:448:269)

Second:

This node is not focusable.
    at MoveIcon.getFocusableElement (webpack-internal:///./src/move_icon.ts:121:15)
    at WorkspaceSvg$$module$build$src$core$workspace_svg.lookUpFocusableNode (webpack-internal:///../blockly/dist/blockly_compressed.js:1312:430)
    at FocusableTreeTraverser$$module$build$src$core$utils$focusable_tree_traverser.findFocusableNodeFor (webpack-internal:///../blockly/dist/blockly_compressed.js:541:146)
    at b (webpack-internal:///../blockly/dist/blockly_compressed.js:543:673)
    at eval (webpack-internal:///../blockly/dist/blockly_compressed.js:544:307)

Screenshots

No response

Browsers

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions