fix: Focus nearest neighbor when deleting a focused block#9599
Merged
fix: Focus nearest neighbor when deleting a focused block#9599
Conversation
BenHenning
requested changes
Feb 25, 2026
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! Largely LGTM but had a few thoughts--PTAL.
Contributor
Author
|
This also fixes #9601 |
Kh0anh
added a commit
to Kh0anh/QuantFlow
that referenced
this pull request
Mar 23, 2026
- Add window-level error handler to catch and suppress the known Blockly v12 "Attempted to focus unregistered tree" runtime error (RaspberryPiFoundation/blockly#9599) - Error occurs when a workspace inside a display:none container receives a focus event before the FocusManager re-registers the tree - Handler prevents the Next.js error overlay from appearing in dev mode while the upstream fix is pending in Blockly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9585
Proposed Changes
This PR adjusts the focus behavior when a focused block is deleted. Previously, deleting a focused block would focus the workspace, which would in turn focus the first (left/topmost) block on the workspace. This could cause large jumps in scroll position. Now, when a focused block is deleted, it moves focus to the closest remaining block, resulting in a smaller (or no) workspace movement.
The tests were partially LLM-generated in response to a list of testcases I specified. I reviewed, modified them, and manually added an additional testcase.