fix: Copy shortcuts before returning them.#9109
Merged
gonfunko merged 1 commit intoRaspberryPiFoundation:developfrom May 29, 2025
Merged
fix: Copy shortcuts before returning them.#9109gonfunko merged 1 commit intoRaspberryPiFoundation:developfrom
gonfunko merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
rachel-fenichel
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR copies the list of keyboard shortcut names returned by
getShortcutNamesByKeyCode(). This works around an issue where, if a keyboard shortcut de-registered itself in its callback, other shortcuts with the same key combo might not be run, because the shortcut registry was iterating this list of shortcut names by reference, and de-registering a shortcut mutates it while it is being iterated by the registry.