fix!: Replace Closure UI CSS classes with Blockly CSS classes#8339
Merged
BeksOmega merged 4 commits intoRaspberryPiFoundation:rc/v12.0.0from Jul 17, 2024
Merged
Conversation
github-actions
bot
added
breaking change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
BeksOmega
suggested changes
Jul 15, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Two little fixes then should be good to go! Thanks for digging into this =)
core/menu.ts
Outdated
| const element = document.createElement('div'); | ||
| // goog-menu is deprecated, use blocklyMenu. May 2020. | ||
| element.className = 'blocklyMenu goog-menu blocklyNonSelectable'; | ||
| // Removed deprecated goog-menu, used blocklyMenu. July 2024. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Removed deprecated goog-menu, used blocklyMenu. July 2024. |
You can just remove this comment!
core/menuitem.ts
Outdated
|
|
||
| // Set class and style | ||
| // goog-menuitem* is deprecated, use blocklyMenuItem*. May 2020. | ||
| // removed deprecated goog-menuitem & goog-menuitem-disabled , used blocklyMenuItem & blocklyMenuItemDisabled. July 2024. |
Contributor
There was a problem hiding this comment.
Suggested change
| // removed deprecated goog-menuitem & goog-menuitem-disabled , used blocklyMenuItem & blocklyMenuItemDisabled. July 2024. |
Same here =)
BeksOmega
reviewed
Jul 15, 2024
core/menuitem.ts
Outdated
| (this.enabled ? '' : 'blocklyMenuItemDisabled goog-menuitem-disabled ') + | ||
| 'blocklyMenuItem ' + | ||
| (this.enabled ? '' : 'blocklyMenuItemDisabled ') + | ||
| (this.checked ? 'blocklyMenuItemSelected goog-option-selected ' : '') + |
Contributor
There was a problem hiding this comment.
Ah actually I see that this goog-option-selected should also be removed. Can you check for other goog-x classes and remove them as well?
1 task
BeksOmega
approved these changes
Jul 16, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the fixes. Once this passes CI I'll get it merged =)
mikeharv
pushed a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Apr 2, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes Replace Closure UI CSS classes with Blockly CSS classes #8286
Proposed Changes
replaces all instances of the deprecated goog-menuitem, goog-menuitem-disabled, and goog-menu CSS classes
with the corresponding blocklyMenuItem, blocklyMenuItemDisabled, and blocklyMenu classes
Reason for Changes
This change ensures that the code
follows the updated styling guidelines and removes dependency on the old Closure UI library.
Test Coverage
Documentation
Additional Information
Please let me know, if any changes are needed.