feat: allow fetching block bounds not including children.#8284
Merged
gonfunko merged 5 commits intoRaspberryPiFoundation:developfrom Jul 10, 2024
Merged
feat: allow fetching block bounds not including children.#8284gonfunko merged 5 commits intoRaspberryPiFoundation:developfrom
gonfunko merged 5 commits intoRaspberryPiFoundation:developfrom
Conversation
BeksOmega
reviewed
Jul 10, 2024
BeksOmega
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7212
Proposed Changes
This PR adds a
getBoundingRectangleWithoutChildren()method to BlockSvg that returns the bounding box for the block alone, not including its children (for C blocks) or subsequent blocks in the stack.Reason for Changes
There was no public API to retrieve this information, and it's useful.