fix: path object not checking theme props#6451
Merged
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom Sep 26, 2022
Merged
fix: path object not checking theme props#6451BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
Conversation
gonfunko
reviewed
Sep 26, 2022
core/renderers/geras/path_object.ts
Outdated
| this.svgPathDark.style.display = ''; | ||
| if (!this.style.colourTertiary) { | ||
| throw new Error( | ||
| 'The renderer did not properly initialize the block style'); |
Contributor
There was a problem hiding this comment.
Maybe specify colourTertiary/colourSecondary in the messages to make it easier to track down?
maribethb
approved these changes
Sep 26, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Somehow some type problem snuck into develop. This fixes them.
Proposed Changes
Makes sure that the geras path object checks for theme properties before it accesses them.
Behavior Before Change
No change in user-facing behavior.
Behavior After Change
No change in user-facing behavior.
Reason for Changes
We like the build to build.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A