Skip to content

Blockly Factory: Bug Fix, Adjust Starter Code#615

Merged
picklesrus merged 1 commit intoRaspberryPiFoundation:developfrom
edauterman:blocklyfactory24_suggestVarBug
Aug 31, 2016
Merged

Blockly Factory: Bug Fix, Adjust Starter Code#615
picklesrus merged 1 commit intoRaspberryPiFoundation:developfrom
edauterman:blocklyfactory24_suggestVarBug

Conversation

@edauterman
Copy link
Copy Markdown
Contributor

@edauterman edauterman commented Aug 31, 2016

Fixed bug for updating flags for custom categories. Also updated the starter code to use document.getElementById for XML elements, and added some more comments.


This change is Reviewable

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@edauterman
Copy link
Copy Markdown
Contributor Author

@picklesrus @vicng @quachtina96


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@picklesrus
Copy link
Copy Markdown
Contributor

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@picklesrus picklesrus merged commit 8d89e62 into RaspberryPiFoundation:develop Aug 31, 2016
@quachtina96
Copy link
Copy Markdown
Contributor

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@maribethb maribethb mentioned this pull request Jun 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants