fix: Fix bug that prevented deleting a variable referenced by two connected blocks (#9563)

gonfunko · web-flow · commit 52d935c815e9 · 2026-01-12T15:57:00.000-08:00
* fix: Fix bug that prevented deleting a variable referenced by two connected blocks

* fix: Remove inadvertent .only
diff --git a/core/connection.ts b/core/connection.ts
@@ -291,7 +291,10 @@ export class Connection {
     }
 
     let event;
-    if (eventUtils.isEnabled()) {
+    if (
+      eventUtils.isEnabled() &&
+      !childConnection.getSourceBlock().isDeadOrDying()
+    ) {
       event = new (eventUtils.get(EventType.BLOCK_MOVE))(
         childConnection.getSourceBlock(),
       ) as BlockMove;
diff --git a/core/variable_map.ts b/core/variable_map.ts
@@ -315,6 +315,8 @@ export class VariableMap
     }
     try {
       for (let i = 0; i < uses.length; i++) {
+        if (uses[i].isDeadOrDying()) continue;
+
         uses[i].dispose(true);
       }
       const variables = this.variableMap.get(variable.getType());
diff --git a/tests/mocha/blocks/variables_test.js b/tests/mocha/blocks/variables_test.js
@@ -30,6 +30,25 @@ suite('Variables', function () {
             'variableTypes': ['', 'type1', 'type2'],
           },
         ],
+        'output': null,
+      },
+      // Block for variable setter.
+      {
+        'type': 'set_var_block',
+        'message0': '%{BKY_VARIABLES_SET}',
+        'args0': [
+          {
+            'type': 'field_variable',
+            'name': 'VAR',
+            'variableTypes': ['', 'type1', 'type2'],
+          },
+          {
+            'type': 'input_value',
+            'name': 'VALUE',
+          },
+        ],
+        'previousStatement': null,
+        'nextStatement': null,
       },
     ]);
     this.variableMap = this.workspace.getVariableMap();
@@ -59,6 +78,21 @@ suite('Variables', function () {
     return block;
   }
 
+  test('can be deleted when two connected blocks reference the same variable', function () {
+    const getter = new Blockly.Block(this.workspace, 'get_var_block');
+    getter.getField('VAR').setValue('1');
+
+    const setter = new Blockly.Block(this.workspace, 'set_var_block');
+    setter.getField('VAR').setValue('1');
+    setter.getInput('VALUE').connection.connect(getter.outputConnection);
+
+    this.variableMap.deleteVariable(this.variableMap.getVariableById('1'));
+    // Both blocks should have been deleted.
+    assert.equal(0, this.workspace.getAllBlocks(false).length);
+    // The variable itself should have been deleted.
+    assert.equal(this.variableMap.getVariableById('1'), undefined);
+  });
+
   suite('allUsedVarModels', function () {
     test('All used', function () {
       createTestVarBlock(this.workspace, '1');

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,8 @@ export class VariableMap`
`315`	`315`	`}`
`316`	`316`	`try {`
`317`	`317`	`for (let i = 0; i < uses.length; i++) {`
	`318`	`+ if (uses[i].isDeadOrDying()) continue;`
	`319`	`+`
`318`	`320`	`uses[i].dispose(true);`
`319`	`321`	`}`
`320`	`322`	`const variables = this.variableMap.get(variable.getType());`