Skip to content

Feature: Reconnect Dialog - #2103

Merged
Jixabon merged 2 commits into
masterfrom
feat/reconnect-dialog
May 10, 2026
Merged

Feature: Reconnect Dialog#2103
Jixabon merged 2 commits into
masterfrom
feat/reconnect-dialog

Conversation

@Jixabon

@Jixabon Jixabon commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

This PR addresses the lack of feedback after clicking the button to reboot the system.

Adds a follow up modal with logic to check the loading success of the home page of the current host. It retries on an interval and will refresh the page when it can reach it successfully.

@Jixabon
Jixabon requested a review from billz April 26, 2026 23:56

@billz billz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement. Just needs locale strings, then good to merge

Comment thread templates/system.php
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<div class="modal-title" id="ModalLabel"><i class="fas fa-sync me-2"></i><?php echo _("Reconnecting"); ?></div>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs en_US locale string

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged over when merged into insiders 👍

Comment thread templates/system.php
</div>
<div class="modal-body">
<div class="col-md-12 mb-3 mt-1" id="system-reconnect-message">
<p><?php echo _("The system is currently rebooting."); ?></p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@Jixabon
Jixabon merged commit f085f9d into master May 10, 2026
3 checks passed
@billz
billz deleted the feat/reconnect-dialog branch July 6, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants