Maintenance: Refactor Javascript - #2078
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
This is another long overdue maintenance / sanity update. Initial smoke test passes. Agreed this will require thorough testing. I also think this is useful... 
|
Member
|
Some observations from testing:
The latter is unrelated to this PR; I'm sure it's been like this for awhile. Better to make them consistent while we're at it, however. Apart from these small things, looks great! |
Contributor
Author
|
@billz I've unfortunately not been able to replicate the WireGuard Keygen issue. As for the button style discrepancies, I'll make note of it and include it in the next round of UI fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a pretty big overhaul/reorganization of the javascript code. It splits everything into modules, making it much easier to find and troubleshoot javascript ui and ajax handling code. Everything runs out of the new app.js file and is conditionally loaded based on the url pathname. This reduces the amount of code running per page load and reduces conflicts and errors failing to find elements that don't exist.
Note: There will be no conflicts due to completely new files. Thorough testing required. Also depending on time of merge and other PRs with JS changes they will need to be updated.