Fix: VPN Providers Mishandled in Unattended Installation - #2026

Opened this PR before reading the contributions/raising an issue. Sorry for that!

@climberomes no worries! PRs are always welcome with or without issues :)

Nice work. This resolves the issue and correctly sets provider ID during unattended installs. One thing I observed is that when running with --yes but without --provider, the installer shows an error instead of skipping:

[✗ error] Invalid VPN provider ID 0 - (Skipped)

Other features (OpenVPN, WireGuard) report 'skipped' when set to 0. Ideally, VPN provider should behave the same way. This could be done by checking for 0 first:

elif [ "$opt" == "pv_option" ]; then
      local value=${!opt}
      # Skip silently if not requested (value is 0)
      if [ "$value" == 0 ]; then
          echo "(Skipped)"
      else
          # Iterate over the VPN provider options
          ...

This isn't a critical error (the installer is able to continue) but would be cleaner and consistent with other features.

Nice work. This resolves the issue and correctly sets provider ID during unattended installs. One thing I observed is that when running with --yes but without --provider, the installer shows an error instead of skipping:

[✗ error] Invalid VPN provider ID 0 - (Skipped)

Other features (OpenVPN, WireGuard) report 'skipped' when set to 0. Ideally, VPN provider should behave the same way. This could be done by checking for 0 first:

elif [ "$opt" == "pv_option" ]; then
      local value=${!opt}
      # Skip silently if not requested (value is 0)
      if [ "$value" == 0 ]; then
          echo "(Skipped)"
      else
          # Iterate over the VPN provider options
          ...

This isn't a critical error (the installer is able to continue) but would be cleaner and consistent with other features.

Great call out. Correct it should skip on 0, not error. Darn edge cases! Commit is in and I can test this once I get a chance.

Got a chance to test the changes after the PR review.

In my recent test through a Docker build, i observed that somehow when --provider is not included as an input flag, pv_option value is still unset (null) and not 0 even with the initialization of pv_option=0. Weirdly enough this was not an issue when --provider is passed in... Given the comment in #2026 (comment) it seems like this portion should work. Maybe this is just an environment issue on my end, however this is an easy thing to account for.

Commit 1d2a223 updates this in the event this is a real issue and not an environment issue.

Test verification was performed. Linked in the description. Can provide logs if needed. but pictures should avoid downloading files.

good to merge. @climberomes many thanks for the PR!