Typo fix in common.sh - #2022
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds sudo to the grep command used to check for existing iptables rules in the network configuration script. This ensures the command can read the iptables rules file (/etc/iptables/rules.v4) in restricted permission environments.
Key Changes
- Modified the
grepcommand on line 839 to run withsudowhen checking for existing iptables rules
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Co-pilot is wrong here: the typo fix is valid but minor. please revise this or open a new PR |
|
I deleted it and generated it with So it cannot read if without sudo |
|
Thanks for the additional context. raspap-webgui/installers/common.sh Lines 849 to 852 in f34cb43 This isn't an issue on clean installs, or when custom OS images are generated with our pi-gen fork. However, if a user executes netfilter-persistent and then runs the installer, sudo will be necessary. |
|
@1208nn good to merge. thanks for the PR |
This pull request makes a minor update to the networking configuration script. The change ensures that the
grepcommand used to check for existing iptables rules is run withsudo, which is necessary for reading the rules file in environments with restricted permissions.