Repository navigation
Commit 215858f
authored
[flutter_tools] Handle RPCError in ScreenshotCommand.runSkia (flutter#196132)
Previously, running `flutter screenshot --type=skia` against an
application with Impeller enabled crashed with an unhandled
`vm_service.RPCError` (`-32000`) because the engine rejects
`_flutter.screenshotSkp` requests under Impeller and
`ScreenshotCommand.runSkia` did not catch `RPCError`. Catch
`vm_service.RPCError` in `ScreenshotCommand.runSkia` and exit cleanly
via `throwToolExit` with the engine's error message.
Previous output:
```
_flutter.screenshotSkp: (-32000) Cannot capture SKP screenshot with Impeller enabled.
#0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:280:34)
flutter#1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1962:25)
flutter#2 VmService._call (package:vm_service/src/vm_service.dart:1974:8)
flutter#3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1905:14)
flutter#4 FlutterVmService._checkedCallServiceExtension (package:flutter_tools/src/vmservice.dart:835:28)
flutter#5 FlutterVmService.screenshotSkp (package:flutter_tools/src/vmservice.dart:1069:12)
flutter#6 ScreenshotCommand.runSkia (package:flutter_tools/src/commands/screenshot.dart:167:54)
<asynchronous suspension>
flutter#7 ScreenshotCommand.runCommand (package:flutter_tools/src/commands/screenshot.dart:123:19)
<asynchronous suspension>
flutter#8 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:876:27)
<asynchronous suspension>
flutter#9 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:174:19)
<asynchronous suspension>
flutter#10 CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
flutter#11 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:689:9)
<asynchronous suspension>
flutter#12 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:174:19)
<asynchronous suspension>
flutter#13 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:619:5)
<asynchronous suspension>
flutter#14 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:379:5)
<asynchronous suspension>
flutter#15 run.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:419:19)
<asynchronous suspension>
flutter#16 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:174:19)
<asynchronous suspension>
flutter#17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:174:19)
<asynchronous suspension>
flutter#18 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:174:19)
<asynchronous suspension>
flutter#19 main (package:flutter_tools/executable.dart:133:3)
<asynchronous suspension>
Feature flags enabled: enable-web, enable-linux-desktop, enable-macos-desktop, enable-windows-desktop, enable-android, enable-ios, cli-animations, enable-native-assets, enable-record-use, enable-swift-package-manager, omit-legacy-version-file, enable-lldb-debugging, enable-uiscene-migration, enable-riscv64, enable-hcpp
```
Current output:
```
The Skia picture request failed: Cannot capture SKP screenshot with Impeller enabled.
```
Fixes flutter#1961191 parent bd40044 commit 215858f
4 files changed
Lines changed: 356 additions & 3 deletions
File tree
- dev/bots
- packages/flutter_tools
- lib/src/commands
- test
- commands.shard/hermetic
- integration.shard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| 174 | + | |
174 | 175 | | |
175 | 176 | | |
176 | 177 | | |
| |||
388 | 389 | | |
389 | 390 | | |
390 | 391 | | |
| 392 | + | |
391 | 393 | | |
392 | 394 | | |
393 | 395 | | |
| |||
605 | 607 | | |
606 | 608 | | |
607 | 609 | | |
| 610 | + | |
608 | 611 | | |
609 | 612 | | |
610 | 613 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
168 | 173 | | |
169 | 174 | | |
170 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
315 | 363 | | |
316 | 364 | | |
317 | 365 | | |
| |||
382 | 430 | | |
383 | 431 | | |
384 | 432 | | |
385 | | - | |
| 433 | + | |
386 | 434 | | |
387 | 435 | | |
| 436 | + | |
388 | 437 | | |
389 | 438 | | |
390 | | - | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
391 | 445 | | |
0 commit comments