feat(bench): added comparison between verify and verifyOneShot#31
feat(bench): added comparison between verify and verifyOneShot#31RafaelGSS merged 1 commit intoRafaelGSS:mainfrom
Conversation
|
If the slowdown confirms, I think it is caused by this commit: nodejs/node@8c4b8b2 |
|
That function ( The definition of that function can be found here: https://github.com/nodejs/node/blob/284e6ac20cc5afe39a0ffeea90b8684f6803d232/lib/internal/validators.js#L419-L422 The difference is now he hides the stackframe. Edit: The source code of Reading the code, I don't think that function can be the issue but is to only significant thing that changed between NodeJS Versions. |
I think I found a regression on
crypto.verifyafter NodeJS 16.x, I was trying to speedup the node-jwa and when I tested on NodeJS 18.x and 19.x, the function was ~4x slower.