Set 'userData' path to executable directory if build is portable#133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the portable experience on Windows.
This addresses issue #79
What this PR does:
The electron build will set the environment variable "PORTABLE_EXECUTABLE_DIR" to the current executable directory if the build is portable. Using this, we can set the 'userData' path to the executables directory. In this case, all files which were previously stored in ".../appdata/roaming/Allusion" will now be stored in ".../[executable_directory]/Allusion". This way, nothing else needs to be changed and the program behaves as expected.
What this PR doesn't do:
Stored paths to folders are still absolute. Which means if Allusion and all images are saved on a external hard drive, and the drive gets assigned another drive letter, it is required to point Allusion to the images folders again.
This can be fixed in a future PR by storing relative paths instead of absolute paths.
To test this feature with a dev build, it is required to set "PORTABLE_EXECUTABLE_DIR" in the launch.json manually to something like "${workspaceFolder}/.portable"