rt_hw_spinlock_t cannot be found on single core include smp_call.h #9771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mysterywolf
approved these changes
Dec 10, 2024
Contributor
|
两个问题： 1：请补全 commit 信息。具体要求参考：https://github.com/plctlab/plct-rt-thread/tree/notes/0.notes#%E5%A6%82%E4%BD%95%E6%8F%90%E4%BA%A4-git-commit 2：我查了一下代码，造成编译不过的原因在于 #ifdef RT_USING_SMP
/**
* Spinlock
*/
typedef struct
{
rt_uint32_t value;
} rt_hw_spinlock_t;
#endif /* RT_USING_SMP */包含的路径大致如下：假设 -> 表示 以上是备忘。 既然 #ifndef __SMP_IPI_H__
#define __SMP_IPI_H__
#include <rtthread.h>
#ifdef RT_USING_SMP
/* callback of smp call */
......
#endif // RT_USING_SMP
#endif // __SMP_IPI_H__ |
This was referenced Dec 25, 2024
Contributor
|
已经在 #9835 中解决了，关闭这个 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
单核在setup.c 文件中#include <smp_call.h> 会找不到rt_hw_spinlock_t定义，必须要打开RT_USING_SMP宏才能include此文件。
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up